Hi Geert, On 22/05/2019 14:48, Geert Uytterhoeven wrote: > Hi Vincenzo, > > On Wed, May 22, 2019 at 3:28 PM Vincenzo Frascino > <vincenzo.frascino@xxxxxxx> wrote: >> The LICENSE directory has recently changed structure and this makes >> spdxcheck fails as per below: >> >> FAIL: "Blob or Tree named 'other' not found" >> Traceback (most recent call last): >> File "scripts/spdxcheck.py", line 240, in <module> >> spdx = read_spdxdata(repo) >> File "scripts/spdxcheck.py", line 41, in read_spdxdata >> for el in lictree[d].traverse(): >> [...] >> KeyError: "Blob or Tree named 'other' not found" >> >> Fix the script to restore the correctness on checkpatch License >> checking. >> >> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> >> Cc: Jeremy Cline <jcline@xxxxxxxxxx> >> Cc: linux-kernel@xxxxxxxxxxxxxxx >> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx> > > Thanks for your patch! > > Looks the issue is already fixed in linux-next: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/spdxcheck.py > Thank you for pointing this out, I missed it. I had a look at the patch in linux-next and seems that the problem is not completely solved by the patch you are referring to, in fact: - For how the code it is written, exceptions directory needs to be parsed as last. The only reason why it seems ok at the moment in linux-next it is because there is no "dual" license appears in SPDX-Licenses field of any "exception". A simple test that consists in adding Apache-2.0 to the SPDX- Licenses of Linux-syscall-note generates still an exception. - The SPDXException calls in the case of "SPDX-Licenses" and "License-Text" use undefined parameters. My patch addresses both the issues, if it helps, I can rebase it on linux-next. Please let me know. > Gr{oetje,eeting}s, > > Geert > -- Regards, Vincenzo
