On Thu, 4 Apr 2019 17:02:10 +0300 "Dmitry V. Levin" <ldv@xxxxxxxxxxxx> wrote: > On Mon, Apr 01, 2019 at 09:41:07AM -0400, Steven Rostedt wrote: > > From: "Dmitry V. Levin" <ldv@xxxxxxxxxxxx> > > > > RISC-V syscall arguments are located in orig_a0,a1..a5 fields > > of struct pt_regs. > > > > Due to an off-by-one bug and a bug in pointer arithmetic > > syscall_get_arguments() was reading s3..s7 fields instead of a1..a5. > > Likewise, syscall_set_arguments() was writing s3..s7 fields > > instead of a1..a5. > > > > Link: http://lkml.kernel.org/r/20190329171221.GA32456@xxxxxxxxxxxx > > > > Fixes: e2c0cdfba7f69 ("RISC-V: User-facing API") > > Cc: Ingo Molnar <mingo@xxxxxxxxxx> > > Cc: Kees Cook <keescook@xxxxxxxxxxxx> > > Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx> > > Cc: Will Drewry <wad@xxxxxxxxxxxx> > > Cc: Palmer Dabbelt <palmer@xxxxxxxxxx> > > Cc: Albert Ou <aou@xxxxxxxxxxxxxxxxx> > > Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx > > Cc: stable@xxxxxxxxxxxxxxx # v4.15+ > > Signed-off-by: Dmitry V. Levin <ldv@xxxxxxxxxxxx> > > Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> > > According to > https://lore.kernel.org/lkml/mhng-8e9b547b-7fe3-43d2-9dea-b217de923605@palmer-si-x1c4/ > the following tag could be added to this patch: > > Acked-by: Palmer Dabbelt <palmer@xxxxxxxxxx> That link isn't actually an ack. Palmer, you OK if I add it? -- Steve
