On 01/04/2019 15:43, Catalin Marinas wrote:
> On Mon, Apr 01, 2019 at 12:20:24PM +0100, Vincenzo Frascino wrote:
>> +static int __init aarch32_alloc_vdso_pages(void)
>> +{
>> + return aarch32_alloc_kuser_vdso_page() &
>> + aarch32_alloc_sigreturn_vdso_page();
>> }
>> arch_initcall(aarch32_alloc_vdso_pages);
>
> It probably doesn't matter much but I'd rather not bit-and two error
> codes. Just return the non-zero one or pick the first (your choice) if
> both are wrong.
>
> (normally, if you want a non-zero random value if any of them failed,
> you'd use bit-or)
>
Actually this is a good advice, I will change the code accordingly in v2.
--
Regards,
Vincenzo
