On 09. 02. 19, 12:25, Borislav Petkov wrote: >> @@ -57,7 +56,7 @@ >> #if defined(CONFIG_TRACE_IRQFLAGS) \ >> || defined(CONFIG_DEBUG_LOCK_ALLOC) \ >> || defined(CONFIG_PREEMPT) >> -.L_restore: >> +SYM_CODE_START_LOCAL_NOALIGN(.L_restore) >> popq %r11 >> popq %r10 >> popq %r9 >> @@ -70,4 +69,5 @@ >> popq %rbp >> ret >> _ASM_NOKPROBE(.L_restore) >> +SYM_CODE_END(.L_restore) > > That local label doesn't even land in the symbol table: > > $ readelf -a arch/x86/entry/thunk_64.o | grep restore > $ > > so no need to touch it, AFAICT. And all local labels, for that matter. Yes, they do not end up in the symbol table. But the macros make clear where is the start of the function and especially where is the end (something like closing bracket '}' in C). If you prefer not annotating local symbols, I can of course drop it from everywhere. But to me it looks more readable to see "here it starts" and "here it ends", still without generating anything to the symbol table. thanks, -- js suse labs
