On 2/8/19 1:43 PM, Michael S. Tsirkin wrote: > On Fri, Feb 08, 2019 at 04:42:39PM +0100, Borislav Petkov wrote: >> On Fri, Feb 08, 2019 at 01:02:53AM -0500, Michael S. Tsirkin wrote: >>> Use linux/mman.h to make sure we get all mmap flags we need. >> Why, asm/mman.h is not enough or is this fixing a build issue or what is that >> patch supposed to address? > Coding style violation: if a linux/foo.h exists then it must > be included in preference to asm/foo.h Huh, I don't see that one in Documentation/process/coding-style.rst > And the specific issue is that a follow-up patch moves code from > asm/mman.h to linux/mman.h so if any one was indirectly using > this header it will now miss the symbols that are being moved. Fair enough. But, if this is the real reason, it belongs in the changelog.
