On Tue, 15 Jan 2019, Vincenzo Frascino wrote: > On 15/01/2019 14:57, Thomas Gleixner wrote: > >> + u64 mask; /* Clocksource mask (mono = raw) */ > > > > mono = raw? This is broken. The VDSO cannot define time different from the > > regular syscall interfaces. > > > > On v2 of this series I had the masks for mono and raw separate, but based on > your comment (the core timekeeper has them duplicated purely for access pattern > optimization and simplicity). I unified them. Could you please provide more > details on what should be done in this case? The mask is the same, but the mult is different. I'm not seing how this is implemented. Both MONO and MONO_RAW invoke do_hres() and use the common mult/shift pair. Thanks, tglx