Hi Firoz, I have one more question: On Tue, Nov 13, 2018 at 2:20 AM Firoz Khan <firoz.khan@xxxxxxxxxx> wrote: > The 2nd option will be the recommended one. For that, I > added the __NR_syscalls macro in uapi/asm/unistd.h along > with __NR_syscall_count asm/unistd.h. The macro __NR_sys- > calls also added for making the name convention same across > all architecture. While __NR_syscalls isn't strictly part > of the uapi, having it as part of the generated header to > simplifies the implementation. We also need to enclose > this macro with #ifdef __KERNEL__ to avoid side effects. Looking at the include/uapi/asm-generic/unistd.h I see that __NR_syscalls is not guarded by the #ifdef __KERNEL__, why should it be guarded for xtensa? If we remove __NR_syscall_count from the uapi header I'd suggest dropping it completely and switching its two current users to __NR_syscalls. -- Thanks. -- Max
