Hi Firoz, On Tue, Nov 6, 2018 at 7:12 AM Firoz Khan <firoz.khan@xxxxxxxxxx> wrote: > My initial patches does have generated-y += unistd_32.h instead of > generic-y += unistd_32.h. > If I remember someone pointed out that this implementation doesn't > look good. So I > replaced to generic-y += unistd_32.h. I've only found the following case, where you did the replacement: https://lkml.org/lkml/2018/8/9/177 and I'm pretty sure that Michal meant that only the missing newline didn't look good. > Sure, I'll change to generated-y += unistd_32.h instead of generic-y > += unistd_32.h. > > Max, this looks ok. right? Yes, generated-y looks goodto me. Could you also please move the line generated-y += syscall_table.h up, so that alphabetical order of the header names is preserved? -- Thanks. -- Max
