On Mon, Nov 05, 2018 at 03:33:01PM -0800, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > -static inline int fls(int x) > +static inline int fls(unsigned int x) > { > - return fls64((unsigned int) x); > + return fls64(x); > } Should it return "unsigned"? Logically it should. I remember doing this and there was some code size increase :-(