On Tue, Sep 18, 2018 at 3:48 PM Guo Ren <ren_guo@xxxxxxxxx> wrote: > > ref: https://lkml.org/lkml/2018/5/18/1068 > > map for_cpu for_device unmap > TO_DEV writeback none writeback none > TO_CPU invalidate invalidate* invalidate invalidate* > BIDIR writeback invalidate writeback invalidate > > Signed-off-by: Guo Ren <ren_guo@xxxxxxxxx> Same comment as for the other patch: Explain why the original version is wrong first. When giving a reference to some other discussion, use the "Link" tag above your Signed-off-by line. To point to a discussion on lkml, lore.kernel.org is the recommended archive, so it would become Link: https://lore.kernel.org/lkml/20180518215548.GH17671@xxxxxxxxxxxxxxxxxxxxx/ Arnd
