On Fri, 14 Sep 2018 07:37:20 PDT (-0700), ren_guo@xxxxxxxxx wrote:
On Wed, Sep 12, 2018 at 04:30:36PM +0200, Arnd Bergmann wrote:
On Wed, Sep 12, 2018 at 3:25 PM Guo Ren <ren_guo@xxxxxxxxx> wrote:
>
> This is the 3th version patchset to add the Linux kernel port for C-SKY(csky).
> Thanks to everyone who provided feedback on the previous version.
>
> This patchset adds architecture support to Linux for C-SKY's 32-bit embedded
> CPU cores and the patches are based on linux-4.18.4
>
> There are two ABI versions with several CPU cores in this patchset:
> ABIv1: ck610 (16-bit instruction, 32-bit data path, VIPT Cache ...)
> ABIv2: ck807 ck810 ck860 (16/32-bit variable length instruction, PIPT Cache,
> SMP ...)
>
> More information: http://en.c-sky.com
This looks good to me overall. I think a good next step would be to get the port
included in linux-next, by preparing a git tree with all the patches and asking
Stephen Rothwell to include it there. Further comments on the architecture
port itself can be done on top of the existing patches. I would suggest you
base the git tree on an -rc release (either 4.19-rc1 or 4.19-rc3) and then never
rebase again.
Nice :) I'll follow the rules.
You have included a couple of drivers in the submission: two timer and
two irqchip drivers. Please leave those out for the moment, and either have
them merged through the respective subsystem trees, or get an Ack
from the maintainers to merge them through your tree.
Ok.
I notice that a lot of the patches have no changeset comments on them.
You should fix that and make a habit of describing every single patch
with a few sentences, even if it seems obvious to you. Have a look at
the changeset descriptions for the nds32 and riscv architectures when
they got merged.
Ok, I'll fixup them.
One big question for me is what to do about time_t. Deepa and I are
in the process of finalizing the system call ABI for 32-bit architectures
with 64-bit time_t, but we are not done yet and it won't be complete
for 4.20. If you target 4.21, that could be a chance to make csky the
first architecture to only need the 64-bit time_t interface, with the
corresponding user space changes.
y2038 is very important and csky32 has the issue. But 4.21 is too late for
us, we really want to get into kernel.org as soon as possible.
We could remove 32-bit time_t in future.
I don't want to hijack this thread, but in RISC-V land we were hoping to have a
user ABI free of 32-bit time_t. Our 32-bit glibc ABI hasn't been finalized
yet, and when I talked to the glibc guys a few weeks ago they were happy to let
us wait until 32-bit time_t can be removed before we stabilize the ABI. We've
been maintaining out-of-tree glibc patches for a while now, so I'd really like
to get them into the next glibc release.
Mapping out the schedule more explicitly, as I'm terrible with dates:
* 4.19-rc4 was 2018-09-16
* 4.19 should be 2018-10-21
* 4.20 should be 2019-01-13 (skipping 2 weeks for the holidays)
* 4.21 merge window should close 2019-01-27
* glibc 2.29 is scheduled for 2019-02-01
That's very tight, but assuming we at least have a prototype of the API so we
can get the rv32i glibc patches in much earlier it might be OK. There was some
talk of being able to use some workarounds to do a 32-bit time_t user ABI
without the cooresponding kernel ABI, so we could always go down that route to
start and then decide to deprecate or not deprecate the 32-bit kernel ABI at
the last minute -- not something I'm fond of doing, but an option.
How close to done do you think the 32-bit time_t will be by the end of the 4.20
merge window? If it's close enough to start our glibc push then that might be
OK.
