On Wed, 19 Sep 2018, Lendacky, Thomas wrote: > > To be compatible with "before this patch" you should probably do: > > if (boot_cpu_data.x86_vendor == X86_VENDOR_HYGON) { > root_ids = hygon_root_ids; > misc_ids = hygon_nb_misc_ids; > link_ids = hygon_nb_link_ids; > } else { > root_ids = amd_root_ids; > misc_ids = amd_nb_misc_ids; > link_ids = amd_nb_link_ids; > } > > That way they are always the AMD values if not your chip. And please can we have a comment why this is called on anything which is not AMD or HYGON. It's all but obvious and clearly unexpected. Thanks, tglx