On 09/18/2018 01:44 PM, Thomas Gleixner wrote: > On Tue, 18 Sep 2018, Eric W. Biederman wrote: >> The function bad_area_nosemaphore always sets si_code to SEGV_MAPERR >> and as such can never return a pkey parameter. Therefore remove the >> unusable pkey parameter from bad_area_nosemaphore. The result of this looks nice to me. It's especially nice to see the scope where we have to pass around the pkey get reduced. I also ran the pkey selftests against the current version of your siginfo-testing branch. Everything passes fine on my pkey-enabled system.