Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> +static inline int kernel_termios_to_user_termios(struct termios2 __user *u,
> + struct ktermios *k)
> +{
> + int err;
> + err = put_user(k->c_iflag, &u->c_iflag);
> + err |= put_user(k->c_oflag, &u->c_oflag);
> + err |= put_user(k->c_cflag, &u->c_cflag);
> + err |= put_user(k->c_lflag, &u->c_lflag);
> + err |= put_user(k->c_line, &u->c_line);
> + err |= copy_to_user(u->c_cc, k->c_cc, NCCS);
> + if (!(k->c_lflag & ICANON)) {
> + err |= put_user(k->c_cc[VMIN], &u->c_cc[_VMIN]);
> + err |= put_user(k->c_cc[VTIME], &u->c_cc[_VTIME]);
> + } else {
> + err |= put_user(k->c_cc[VEOF], &u->c_cc[VEOF]);
> + err |= put_user(k->c_cc[VEOL], &u->c_cc[VEOL]);
> + }
> + err |= put_user(k->c_ispeed, &u->c_ispeed);
> + err |= put_user(k->c_ospeed, &u->c_ospeed);
> + return err;
> +}
Can you make this use || instead of |= ? That way if put_user() uses a
goto-out-of-asm it may be a lot more efficient, both in the normal case and
the error case.
David
