On Wed, Sep 5, 2018 at 2:08 PM Guo Ren <ren_guo@xxxxxxxxx> wrote: > > This is the 3th version patchset to add the Linux kernel port for C-SKY(csky). > Thanks to everyone who provided feedback on the previous version. > > This patchset adds architecture support to Linux for C-SKY's 32-bit embedded > CPU cores and the patches are based on linux-4.18.4 I looked at all patches again, overall this seems well done, thanks for addressing all the prior feedback. Most of my comments are are for fairly unimportant issues, the one thing I found that needs to be properly addressed is the asm/io.h header, which should implement the I/O accessors as your hardware requires them. Arnd