On 21/08/2018 13:20, Borislav Petkov wrote: > On Tue, Aug 21, 2018 at 07:04:23PM +0800, Pu Wen wrote: >> Sure, JV will negotiate with AMD and make sure only JV use family 18h and >> AMD won't use family 0x18h, which will make the patch tight and clear. >> >> What's the best way to adapt for EDAC driver? >> * To simplify the code based on AMD won't do family 0x18 and remove >> vendor checking. > > That, provided AMD won't use family 0x18. > But then I don't see the point of adding the Hygon vendor, since any check can be simplified: (AMD || HYGON) --> AMD (AMD && fam = 17h) || (HYGON && fam = 18h) --> AMD && (fam = 17h || fam = 18h) (AMD && fam = 17h) || HYGON --> AMD && (fam = 17h || fam = 18h) etc. Anyway, I don't care much either way. Paolo
