On Monday, August 13, 2018 6:22:16 PM CEST Pu Wen wrote: > On 2018/8/12 17:55, Rafael J. Wysocki wrote: > > On Sat, Aug 11, 2018 at 3:36 PM Pu Wen <puwen@xxxxxxxx> wrote: > >> > >> Enable ACPI cpufreq driver support for Hygon by adding family ID check > >> along with AMD. > >> > >> As Hygon platforms have SMBus device(PCI device ID 0x790b), enable Hygon > >> support to function amd_freq_sensitivity_init(). > >> > >> Signed-off-by: Pu Wen <puwen@xxxxxxxx> > > > > Is there any technical difference between HYGON and AMD? > > For ACPI cpufreq patch, you are right. But for the whole point of view, > there has some technical difference between Hygon Dhyana and AMD Family > 17h. > For cpufreq if not added X86_VENDOR_HYGON codes, this driver will not > work functionally on Hygon platforms. > > > > > You seem to be mechanically adding X86_VENDOR_HYGON wherever > > X86_VENDOR_AMD is used. > > X86_VENDOR_HYGON is not mechanically added wherever X86_VENDOR_AMD is > used, we have reviewed and tested the features wherever X86_VENDOR_HYGON > is needed. > > As Hygon Dhyana can share code path with AMD family 17h, to minimize the > code duplication, we choose to reuse the AMD's codes here. OK The cpufreq changes are fine by me. Thanks!
