Re: [PATCH v14 10/22] selftests/vm: fix alloc_random_pkey() to make it really random

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ram Pai <linuxram@xxxxxxxxxx>, shuahkh@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v14 10/22] selftests/vm: fix alloc_random_pkey() to make it really random
From: Dave Hansen <dave.hansen@xxxxxxxxx>
Date: Wed, 18 Jul 2018 08:45:26 -0700
Cc: mpe@xxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, x86@xxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, mingo@xxxxxxxxxx, mhocko@xxxxxxxxxx, bauerman@xxxxxxxxxxxxxxxxxx, fweimer@xxxxxxxxxx, msuchanek@xxxxxxx, aneesh.kumar@xxxxxxxxxxxxxxxxxx
In-reply-to: <1531835365-32387-11-git-send-email-linuxram@us.ibm.com>
Openpgp: preference=signencrypt
References: <1531835365-32387-1-git-send-email-linuxram@us.ibm.com> <1531835365-32387-11-git-send-email-linuxram@us.ibm.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 07/17/2018 06:49 AM, Ram Pai wrote:
> alloc_random_pkey() was allocating the same pkey every time.
> Not all pkeys were geting tested. fixed it.

This fixes a real issue but also unnecessarily munges whitespace.  If
you rev these again, please fix the munging.  Otherwise:

Acked-by: Dave Hansen <dave.hansen@xxxxxxxxx>

References:
- [PATCH v14 00/22] selftests, powerpc, x86 : Memory Protection Keys
  - From: Ram Pai
- [PATCH v14 10/22] selftests/vm: fix alloc_random_pkey() to make it really random
  - From: Ram Pai

Prev by Date: Re: [PATCH v14 09/22] selftests/vm: fixed bugs in pkey_disable_clear()
Next by Date: Re: [PATCH v14 11/22] selftests/vm: introduce two arch independent abstraction
Previous by thread: [PATCH v14 10/22] selftests/vm: fix alloc_random_pkey() to make it really random
Next by thread: [PATCH v14 11/22] selftests/vm: introduce two arch independent abstraction
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]