On Thu, 07 Jun 2018 22:07:26 +0530 "Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxxxxxxx> wrote: > Masami Hiramatsu wrote: > > On Thu, 07 Jun 2018 17:07:00 +0530 > > "Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxxxxxxx> wrote: > > > >> Masami Hiramatsu wrote: > >> > Don't call the ->break_handler() from the arm kprobes code, > >> ^^^ powerpc > >> > >> > because it was only used by jprobes which got removed. > >> > > >> > This also makes skip_singlestep() a static function since > >> > only ftrace-kprobe.c is using this function. > >> > > >> > Signed-off-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx> > >> > Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> > >> > Cc: Paul Mackerras <paulus@xxxxxxxxx> > >> > Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx> > >> > Cc: "Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxxxxxxx> > >> > Cc: linuxppc-dev@xxxxxxxxxxxxxxxx > >> > --- > >> > arch/powerpc/include/asm/kprobes.h | 10 ---------- > >> > arch/powerpc/kernel/kprobes-ftrace.c | 16 +++------------- > >> > arch/powerpc/kernel/kprobes.c | 31 +++++++++++-------------------- > >> > 3 files changed, 14 insertions(+), 43 deletions(-) > >> > >> With 2 small comments... > > > > 2 ? or 1 ? > > Two, with one in the commit log above :) Oops, sorry I missed it. yeah, the comment above is my mistake. I'll fix it. Thanks! -- Masami Hiramatsu <mhiramat@xxxxxxxxxx>
