On Fri, May 18, 2018 at 2:17 AM Jiri Slaby <jslaby@xxxxxxx> wrote:
> GLOBAL had several meanings and is going away. In this patch, convert
> all the inner function labels marked with GLOBAL to use SYM_INNER_LABEL
> instead.
> Note that retint_user needs not be global, perhaps since commit
> 2ec67971facc ("x86/entry/64/compat: Remove most of the fast system call
> machinery"), where entry_64_compat's caller was removed. So mark the
> label as LOCAL.
> -GLOBAL(entry_SYSCALL_64_after_hwframe)
> +SYM_INNER_LABEL(entry_SYSCALL_64_after_hwframe, SYM_L_GLOBAL)
I've missed all the context here. I agree that GLOBAL is misleading, and
"inner label" is nice. But this is a rather wordy macro. Would:
INNER_LABEL_GLOBAL(name)
be better? (With just INNER_LABEL(name) for the local version?)
