On Wed, May 16, 2018 at 04:09:29PM -0700, H. Peter Anvin wrote: > On 05/16/18 08:49, Dave Martin wrote: > > > > Since <linux/auxvec.h> only contains #defines, it may be enough for arch > > <asm/auxvec.h> headers to include <linux/auxvec.h>. > > > > <asm/auxvec.h> doesn't seem to have any reason to exist at all. If > anyone includes it now, they are Doing It Wrong[TM] since > <linux/auxvec.h> includes <asm/auxvec.h>. Sounds good. BTW there probably does need to be a check for kernel-internal use of #ifdef AT_* etc. I saw some instances in arch/um and a few other weird places. They might not matter but there might be code that's indirectly enabled only for certain archs via the AT_* macros. Rich