On Thu, 3 May 2018 21:25:08 +0800 "Du, Changbin" <changbin.du@xxxxxxxxx> wrote: > I think fix_to_virt() is designed for constant idx only. So I think we should > fix it at the caller side by replacing it with __fix_to_virt(). > > --- a/arch/arm/mm/mmu.c > +++ b/arch/arm/mm/mmu.c > @@ -1599,7 +1599,7 @@ static void __init early_fixmap_shutdown(void) > pte_t *pte; > struct map_desc map; > > - map.virtual = fix_to_virt(i); > + map.virtual = __fix_to_virt(i); > pte = pte_offset_early_fixmap(pmd_off_k(map.virtual), map.virtual); That's a better solution than the current patch. -- Steve