Re: [PATCH -tip v2 4/7] kprobes: Replace %p with other pointer types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
Subject: Re: [PATCH -tip v2 4/7] kprobes: Replace %p with other pointer types
From: Steven Rostedt <rostedt@xxxxxxxxxxx>
Date: Thu, 26 Apr 2018 21:13:51 -0400
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, Ingo Molnar <mingo@xxxxxxxxxx>, "H . Peter Anvin" <hpa@xxxxxxxxx>, x86@xxxxxxxxxx, Ananth N Mavinakayanahalli <ananth@xxxxxxxxxx>, Anil S Keshavamurthy <anil.s.keshavamurthy@xxxxxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>, Jon Medhurst <tixy@xxxxxxxxxx>, Will Deacon <will.deacon@xxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, Heiko Carstens <heiko.carstens@xxxxxxxxxx>, "Tobin C . Harding" <me@xxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Thomas Richter <tmricht@xxxxxxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, acme@xxxxxxxxxx, brueckner@xxxxxxxxxxxxxxxxxx, schwidefsky@xxxxxxxxxx, stable@xxxxxxxxxxxxxxx
Dmarc-filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3F392184F
In-reply-to: <152473020349.8819.11597612324633031612.stgit@devbox>
References: <152473007907.8819.10449983839199591406.stgit@devbox> <152473020349.8819.11597612324633031612.stgit@devbox>

On Thu, 26 Apr 2018 17:10:03 +0900
Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:

> Replace %p with appropriate pointer types (or just remove it)
>  - Use %pS if possible
>  - Use %px only for the function right before BUG().
>  - Remove unneeded error message.

I'm not sure "right before BUG()" is legitimate for using %px. Why not
still use %pS?

-- Steve

Follow-Ups:
- Re: [PATCH -tip v2 4/7] kprobes: Replace %p with other pointer types
  - From: Masami Hiramatsu

References:
- [PATCH -tip v2 0/7] kprobes: Fix %p in kprobes
  - From: Masami Hiramatsu
- [PATCH -tip v2 4/7] kprobes: Replace %p with other pointer types
  - From: Masami Hiramatsu

Prev by Date: Re: [PATCH 2/5] ide: kill ide_toggle_bounce
Next by Date: Re: [PATCH -tip v2 0/7] kprobes: Fix %p in kprobes
Previous by thread: [PATCH -tip v2 4/7] kprobes: Replace %p with other pointer types
Next by thread: Re: [PATCH -tip v2 4/7] kprobes: Replace %p with other pointer types
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]