On Fri, 20 Apr 2018 09:38:04 -0500 "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> wrote: > Filling in struct siginfo before calling force_sig_info a tedious and > error prone process, where once in a great while the wrong fields > are filled out, and siginfo has been inconsistently cleared. > > Simplify this process by using the helper force_sig_fault. Which > takes as a parameters all of the information it needs, ensures > all of the fiddly bits of filling in struct siginfo are done properly > and then calls force_sig_info. > > In short about a 5 line reduction in code for every time force_sig_info > is called, which makes the calling function clearer. > > Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx> > Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx> > Cc: linux-s390@xxxxxxxxxxxxxxx > Signed-off-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> > --- > arch/s390/kernel/traps.c | 32 ++++++-------------------------- > arch/s390/mm/fault.c | 23 ++++++----------------- > 2 files changed, 12 insertions(+), 43 deletions(-) Compiles & boots. Comparing old vs. new the same values are set in siginfo. Looks good. Acked-by: Martin Schwidefsky >schwidefsky@xxxxxxxxxx> -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
