On Mon, Mar 19, 2018 at 3:51 AM, Guo Ren <ren_guo@xxxxxxxxx> wrote: > +++ b/arch/csky/include/uapi/asm/fcntl.h > @@ -0,0 +1,13 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd. > +#ifndef __ASM_CSKY_FCNTL_H > +#define __ASM_CSKY_FCNTL_H > + > +#define O_DIRECTORY 040000 > +#define O_NOFOLLOW 0100000 > +#define O_DIRECT 0200000 > +#define O_LARGEFILE 0400000 > + > +#include <asm-generic/fcntl.h> This should just use the generic file without overrides: Please don't diverge from the generic syscall ABI. > --- /dev/null > +++ b/arch/csky/include/uapi/asm/stat.h > @@ -0,0 +1,86 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd. > +#ifndef _CSKY_STAT_H > +#define _CSKY_STAT_H > + > +struct __old_kernel_stat { > + unsigned short st_dev; Same here: no need for __old_kernel_stat or the headers on new architectures. Arnd