Hi Daniel, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [also build test ERROR on next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Daniel-Kurtz/earlycon-Fix-__earlycon_table-stride-again/20180317-180525 config: h8300-h8300h-sim_defconfig (attached as .config) compiler: h8300-linux-gcc (GCC) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=h8300 All errors (new ones prefixed by >>): In file included from include/asm-generic/bitops/le.h:6:0, from arch/h8300/include/asm/bitops.h:177, from include/linux/bitops.h:38, from include/linux/kernel.h:11, from include/linux/clk.h:16, from drivers/tty/serial/sh-sci.c:24: arch/h8300/include/asm/byteorder.h:5:0: warning: "__BIG_ENDIAN" redefined #define __BIG_ENDIAN __ORDER_BIG_ENDIAN__ In file included from <command-line>:0:0: include/linux/kconfig.h:8:0: note: this is the location of the previous definition #define __BIG_ENDIAN 4321 >> drivers/tty/serial/sh-sci.c:3278:29: error: port_cfg causes a section type conflict with __UNIQUE_ID___earlycon_hscif28 static struct plat_sci_port port_cfg __initdata; ^~~~~~~~ In file included from include/linux/serial_sci.h:6:0, from drivers/tty/serial/sh-sci.c:45: include/linux/compiler-gcc.h:193:45: note: '__UNIQUE_ID___earlycon_hscif28' was declared here #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ include/linux/serial_core.h:366:34: note: in definition of macro '_OF_EARLYCON_DECLARE' static const struct earlycon_id unique_id \ ^~~~~~~~~ include/linux/compiler_types.h:53:22: note: in expansion of macro '___PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^~~~~~~~ include/linux/compiler-gcc.h:193:29: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^~~~~~~ include/linux/compiler_types.h:53:22: note: in expansion of macro '___PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^~~~~~~~ include/linux/compiler-gcc.h:193:37: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^~~~~~~ include/linux/serial_core.h:377:9: note: in expansion of macro '__UNIQUE_ID' __UNIQUE_ID(__earlycon_##_name)) ^~~~~~~~~~~ drivers/tty/serial/sh-sci.c:3330:1: note: in expansion of macro 'OF_EARLYCON_DECLARE' OF_EARLYCON_DECLARE(hscif, "renesas,hscif", hscif_early_console_setup); ^~~~~~~~~~~~~~~~~~~ vim +3278 drivers/tty/serial/sh-sci.c ^1da177e drivers/serial/sh-sci.c Linus Torvalds 2005-04-16 3272 7b6fd3bf drivers/serial/sh-sci.c Magnus Damm 2009-12-14 3273 #ifdef CONFIG_SERIAL_SH_SCI_CONSOLE 7b6fd3bf drivers/serial/sh-sci.c Magnus Damm 2009-12-14 3274 early_platform_init_buffer("earlyprintk", &sci_driver, 7b6fd3bf drivers/serial/sh-sci.c Magnus Damm 2009-12-14 3275 early_serial_buf, ARRAY_SIZE(early_serial_buf)); 7b6fd3bf drivers/serial/sh-sci.c Magnus Damm 2009-12-14 3276 #endif 0b0cced1 drivers/tty/serial/sh-sci.c Yoshinori Sato 2015-12-24 3277 #ifdef CONFIG_SERIAL_SH_SCI_EARLYCON dd076cff drivers/tty/serial/sh-sci.c Matthias Kaehlcke 2017-10-09 @3278 static struct plat_sci_port port_cfg __initdata; 0b0cced1 drivers/tty/serial/sh-sci.c Yoshinori Sato 2015-12-24 3279 :::::: The code at line 3278 was first introduced by commit :::::: dd076cffb8cd675a8973fc9b6cea0c04be6f0111 serial: sh-sci: Fix init data attribute for struct 'port_cfg' :::::: TO: Matthias Kaehlcke <mka@xxxxxxxxxxxx> :::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip