Re: [PATCH v12 1/3] mm, powerpc, x86: define VM_PKEY_BITx bits if CONFIG_ARCH_HAS_PKEYS is enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ram Pai <linuxram@xxxxxxxxxx>, mpe@xxxxxxxxxxxxxx, mingo@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH v12 1/3] mm, powerpc, x86: define VM_PKEY_BITx bits if CONFIG_ARCH_HAS_PKEYS is enabled
From: Dave Hansen <dave.hansen@xxxxxxxxx>
Date: Mon, 26 Feb 2018 13:12:46 -0800
Cc: linuxppc-dev@xxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, x86@xxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, paulus@xxxxxxxxx, khandual@xxxxxxxxxxxxxxxxxx, aneesh.kumar@xxxxxxxxxxxxxxxxxx, bsingharora@xxxxxxxxx, hbabu@xxxxxxxxxx, mhocko@xxxxxxxxxx, bauerman@xxxxxxxxxxxxxxxxxx, ebiederm@xxxxxxxxxxxx, corbet@xxxxxxx, arnd@xxxxxxxx, fweimer@xxxxxxxxxx, msuchanek@xxxxxxxx
In-reply-to: <1519257138-23797-2-git-send-email-linuxram@us.ibm.com>
References: <1519257138-23797-1-git-send-email-linuxram@us.ibm.com> <1519257138-23797-2-git-send-email-linuxram@us.ibm.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 02/21/2018 03:52 PM, Ram Pai wrote:
> VM_PKEY_BITx are defined only if CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS
> is enabled. Powerpc also needs these bits. Hence lets define the
> VM_PKEY_BITx bits for any architecture that enables
> CONFIG_ARCH_HAS_PKEYS.

Your fixed version looks fine to me.

Reviewed-by: Dave Hansen <dave.hansen@xxxxxxxxx>

References:
- [PATCH v12 0/3] mm, x86, powerpc: Enhancements to Memory Protection Keys.
  - From: Ram Pai
- [PATCH v12 1/3] mm, powerpc, x86: define VM_PKEY_BITx bits if CONFIG_ARCH_HAS_PKEYS is enabled
  - From: Ram Pai

Prev by Date: Re: arc: mm->mmap_sem gets locked in do_page_fault() in case of OOM killer invocation
Next by Date: Re: [PATCH v12 2/3] mm, powerpc, x86: introduce an additional vma bit for powerpc pkey
Previous by thread: Re: [PATCH v12 1/3] mm, powerpc, x86: define VM_PKEY_BITx bits if CONFIG_ARCH_HAS_PKEYS is enabled
Next by thread: [PATCH v12 3/3] mm, x86, powerpc: display pkey in smaps only if arch supports pkeys
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]