On Sun, Feb 25, 2018 at 05:27:11PM +0530, Aneesh Kumar K.V wrote: > > > On 02/24/2018 06:35 AM, Ram Pai wrote: > >On Fri, Feb 23, 2018 at 03:11:45PM +0800, kbuild test robot wrote: > >>Hi Ram, > >> > >>Thank you for the patch! Yet something to improve: > >> > >>[auto build test ERROR on linus/master] > >>[also build test ERROR on v4.16-rc2 next-20180222] > >>[if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > >> > >> chmod +x ~/bin/make.cross > >...snip.. > >> # save the attached .config to linux build tree > >> make.cross ARCH=powerpc > >> > >>Note: the linux-review/Ram-Pai/mm-x86-powerpc-Enhancements-to-Memory-Protection-Keys/20180223-042743 HEAD c5692bca45543c242ffca15c811923e4c548ed19 builds fine. > >> It only hurts bisectibility. > > > >oops, it broke git-bisect on powerpc :-( > >The following change will fix it. This should nail it down. > > > >diff --git a/arch/powerpc/include/asm/pkeys.h > >b/arch/powerpc/include/asm/pkeys.h > >index 0409c80..0b3b669 100644 > >--- a/arch/powerpc/include/asm/pkeys.h > >+++ b/arch/powerpc/include/asm/pkeys.h > >@@ -25,6 +25,7 @@ > > # define VM_PKEY_BIT1 VM_HIGH_ARCH_1 > > # define VM_PKEY_BIT2 VM_HIGH_ARCH_2 > > # define VM_PKEY_BIT3 VM_HIGH_ARCH_3 > > # define VM_PKEY_BIT4 VM_HIGH_ARCH_4 > >+#elif !defined(VM_PKEY_BIT4) > >+# define VM_PKEY_BIT4 VM_HIGH_ARCH_4 > >#endif > > > > Why don't you remove this powerpc definition completely in this > patch? That was my thought too, but refrained from sneaking in the changes into the patch, to maintain the integrity of all the reviewed-by. Was planning on sending a seperate patch to remove the powerpc definition entirely. RP
