Re: [PATCH v11 6/9] LPC: Support the LPC host on Hip06/Hip07 with DT bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21/01/2018 17:54, Randy Dunlap wrote:
On 01/21/2018 04:27 AM, John Garry wrote:
diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index 57e011d..91debe4 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -65,6 +65,14 @@ config BRCMSTB_GISB_ARB
 	  arbiter. This driver provides timeout and target abort error handling
 	  and internal bus master decoding.

+config HISILICON_LPC
+	bool "Support for ISA I/O space on Hisilicon hip06/7"
+	depends on (ARM64 && (ARCH_HISI || COMPILE_TEST))
+	select INDIRECT_PIO
+	help
+	  Driver needed for some legacy ISA devices attached to Low-Pin-Count
+	  on Hisilicon hip06/7 SoC.

Hi,
Why is this config symbol bool instead of tristate?

thanks,

Hi Randy,

Considering the nature of this driver, and the fact that it provides an IO space region through the logical PIO framework introduced, it does not make sense to have it as a loadable module.

A specific issue is that one of our boards uses this host for the UART console (through 8250-compatible device in BMC), so would want it in the kernel image.

I will add a note in the commit message and maybe config description explaining this.

Thanks,
John







[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux