On Tue, 2 Jan 2018, David Howells wrote: > Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote: > > > > #define INIT_CPU_TIMERS(s) \ > > ... > > That macro is only used in init_task.c Why not moving it there and get rid > > of the whole macro maze in the header file? > > The reason I didn't get rid of it is that it's got more than one expansion > point. Same for INIT_PREV_CPUTIME and INIT_PID_LINK. Ah, sorry I missed that. So yes, the current patch is fine. Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>