On 04/01/18 12:25 AM, Horia Geantă wrote:
+#include <linux/io-64-nonatomic-hi-lo.h>
Typo: lo-hi should be used instead (see previous patch versions).
Please add in the commit message the explanation (which was there in v8 but
removed in v9):
To be consistent with CAAM engine HW spec: in case of 64-bit registers,
irrespective of device endianness, the lower address should be read from
/ written to first, followed by the upper address. Indeed the I/O
accessors in CAAM driver currently don't follow the spec, however this
is a good opportunity to fix the code.
Ok, well I just copied what the latest code did. I assumed that seeing
it was cleaned up very recently that they would have done it correctly.
/*
* Architecture-specific register access methods
@@ -136,7 +136,6 @@ static inline void clrsetbits_32(void __iomem *reg, u32 clear, u32 set)
* base + 0x0000 : least-significant 32 bits
* base + 0x0004 : most-significant 32 bits
*/
-#ifdef CONFIG_64BIT
static inline void wr_reg64(void __iomem *reg, u64 data)
{
if (caam_little_end)
Since the 2 cases (32/64-bit) are merged, caam_imx should be accounted for the
logic to stay the same.
Oops, my mistake. I'll fix this and the above and send a revised set.
Logan
