Kees Cook <keescook@xxxxxxxxxxxx> writes: > On Wed, Dec 13, 2017 at 1:25 AM, Michal Hocko <mhocko@xxxxxxxxxx> wrote: >> >> Hi, >> I am resending with some minor updates based on Michael's review and >> ask for inclusion. There haven't been any fundamental objections for >> the RFC [1] nor the previous version [2]. The biggest discussion >> revolved around the naming. There were many suggestions flowing >> around MAP_REQUIRED, MAP_EXACT, MAP_FIXED_NOCLOBBER, MAP_AT_ADDR, >> MAP_FIXED_NOREPLACE etc... > > With this named MAP_FIXED_NOREPLACE (the best consensus we've got on a > name), please consider this series: > > Acked-by: Kees Cook <keescook@xxxxxxxxxxxx> I don't feel like I'm actually qualified to ack the mm and binfmt changes, but everything *looks* correct to me, and you've fixed the flag numbering such that it can go in mman-common.h as I suggested. So if the name was MAP_FIXED_NOREPLACE I would also be happy with it. Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> I can resubmit with the name changed if that's what it takes. cheers
