2017-11-08 17:48 GMT+08:00 Arnd Bergmann <arnd@xxxxxxxx>: > On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu <green.hu@xxxxxxxxx> wrote: >> From: Greentime Hu <greentime@xxxxxxxxxxxxx> >> >> Signed-off-by: Vincent Chen <vincentc@xxxxxxxxxxxxx> >> Signed-off-by: Greentime Hu <greentime@xxxxxxxxxxxxx> > >> + >> +/* This is defined for head.S to use due to device tree is not yet built. */ >> +#define L2CC_PA_BASE 0x90F00000 > > This looks problematic, since it prevents you from using the same head.S for > multiple SoCs that have different L2 controllers or that have them at different > addresses. > > What does head.S actually do to the L2CC? Could the boot protocol require > that to be done by the boot loader before entering the kernel instead? > Thanks. It will disable and invalidate L2 cache. I think we can do these things in bootloader. I will refine it in the next version patch.