On Wed, Nov 01, 2017 at 11:42:29AM +0000, Catalin Marinas wrote: > On Tue, Oct 31, 2017 at 03:50:53PM +0000, Dave P Martin wrote: > > Currently the regset API doesn't allow for the possibility that > > regsets (or at least, the amount of meaningful data in a regset) > > may change in size. > > > > In particular, this results in useless padding being added to > > coredumps if a regset's current size is smaller than its > > theoretical maximum size. > > > > This patch adds a get_size() function to struct user_regset. > > Individual regset implementations can implement this function to > > return the current size of the regset data. A regset_size() > > function is added to provide callers with an abstract interface for > > determining the size of a regset without needing to know whether > > the regset is dynamically sized or not. > > > > The only affected user of this interface is the ELF coredump code: > > This patch ports ELF coredump to dump regsets with their actual > > size in the coredump. This has no effect except for new regsets > > that are dynamically sized and provide a get_size() implementation. > > > > Signed-off-by: Dave Martin <Dave.Martin@xxxxxxx> > > Reviewed-by: Alex Bennée <alex.bennee@xxxxxxxxxx> > > Reviewed-by: Catalin Marinas <catalin.marinas@xxxxxxx> > > Cc: Oleg Nesterov <oleg@xxxxxxxxxx> > > Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx> > > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > > Cc: Ingo Molnar <mingo@xxxxxxxxxx> > > Cc: "H. Peter Anvin" <hpa@xxxxxxxxx> > > Cc: Dmitry Safonov <dsafonov@xxxxxxxxxxxxx> > > Cc: H. J. Lu <hjl.tools@xxxxxxxxx> > > > > --- > > > > **Dropped** Reviewed-by: Alex Bennée <alex.bennee@xxxxxxxxxx> > > **Dropped** Reviewed-by: Catalin Marinas <catalin.marinas@xxxxxxx> > > (due to bug fix applied against v4 of this patch.) > > It seems that the Reviewed-by tags are still there ;). Anyway, on the Oops, looks like that only happened on this patch. I've removed Alex's R-b from my own version in case of repost -- can you also do the same? > new patch: > > Reviewed-by: Catalin Marinas <catalin.marinas@xxxxxxx> Cheers ---Dave
