On Fri, 18 Aug 2017 14:44:15 +0100 Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote: > >> It appears the stuff above needs to be move inside the double-include > >> guard (which oddly enough does not cover the entire file) > > > > Why was this moved to the header file? To fulfill some checkpatch > > warning? > > > > Yes. My preference is to ignore that checkpatch warning. The section variables are created by linker magic, and not normal "extern" variables. They are only used in one location, and I like to keep them where they are used, and not be something other places might think they can be used. In other words, keep them by the C code, and out of headers. Tracepoints and linker/asm work always triggers a lot of bogus checkpatch warnings. Which is unfortunate. :-/ Thanks! -- Steve
