Hi Sam, 2017-07-10 17:42 GMT+09:00 Sam Ravnborg <sam@xxxxxxxxxxxx>: > Hi Masahiro. > > On Mon, Jul 10, 2017 at 03:32:32AM +0900, Masahiro Yamada wrote: >> In v4.12-rc1, we had a big progress for headers_install. >> All (and only) headers under UAPI directories are exported. >> However, asm-generic wrappers are still exceptions because >> most of arch/*/include/asm/Kbuild include "generic-y" for >> exported headers. As a result, many of generic-wrappers to be >> exported are generated outside UAPI directories. >> >> To finish de-coupling UAPI, "generic-y" for exported headers >> should be moved to arch/*/include/uapi/asm/Kbuild. >> >> With those cleanups, the logic of headers_install will become >> even simpler. UAPI will be completely self-contained. >> >> This series is based on: >> commit 19bf2e0ef18ec8a7284ecc83459a2664cb885cd5 >> >> Changes for v2: >> - rebase on the latest in the mainline in order to avoid merge conflicts > > Series looks good. > > In several of your patches assignments are moved to the arch > specific uapi file, but the same assignment are already present in > include/uapi/asm-generic/Kbuild.asm so the assignment is redundant. > > For example: > $ARCH uapi Kbuild: > generic-y += errno.h > > uapi/asm-generic Kbuild: > mandatory-y += errno.h > > As this patch-set is touching all arch files this > could be a good opportunity to clean this up too. > > But maybe mandatory-y and generic-y do something different, > and both are needed. In wich cases all is good. > Thanks for your review, and you have a good point. If neither arch-own header implementation is found nor generic-y is specified, the build system can automatically generate generic wrappers for "mandatory" headers. I also considered of it, but I wanted to take my time. I simply moved generic-y without introducing any logical change in order to make this series less controversial. One point of forcing explicit generic-y might be, to give arch maintainers an opportunity to judge if falling back to asm-generic one works or not. -- Best Regards Masahiro Yamada
