On Thu, 29 Jun 2017 01:39:25 PDT (-0700), tklauser@xxxxxxxxxx wrote:
> On 2017-06-28 at 20:55:35 +0200, Palmer Dabbelt <palmer@xxxxxxxxxxx> wrote:
> [...]
>> diff --git a/arch/riscv/include/asm/device.h b/arch/riscv/include/asm/device.h
>> new file mode 100644
>> index 000000000000..28975e528d2f
>> --- /dev/null
>> +++ b/arch/riscv/include/asm/device.h
>> @@ -0,0 +1,27 @@
>> +/*
>> + * Copyright (C) 2016 SiFive
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License
>> + * as published by the Free Software Foundation, version 2.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + */
>> +
>> +
>> +#ifndef _ASM_RISCV_DEVICE_H
>> +#define _ASM_RISCV_DEVICE_H
>> +
>> +#include <linux/sysfs.h>
>> +
>> +struct dev_archdata {
>> + struct dma_map_ops *dma_ops;
>> +};
>
> The dma_ops member isn't used in any arch code or driver from what I can
> tell (I checked against your riscv-for-submission-v3 branch). Could
> device.h from asm-generic be used instead, or did I miss something?
I think you're right. I'll include this
diff --git a/arch/riscv/include/asm/device.h b/arch/riscv/include/asm/device.h
index 28975e528d2f..a310c2c26101 100644
--- a/arch/riscv/include/asm/device.h
+++ b/arch/riscv/include/asm/device.h
@@ -11,17 +11,9 @@
* GNU General Public License for more details.
*/
-
#ifndef _ASM_RISCV_DEVICE_H
#define _ASM_RISCV_DEVICE_H
-#include <linux/sysfs.h>
-
-struct dev_archdata {
- struct dma_map_ops *dma_ops;
-};
-
-struct pdev_archdata {
-};
+#include <asm-generic/device.h>
#endif /* _ASM_RISCV_DEVICE_H */
in the v4
>
>> +
>> +struct pdev_archdata {
>> +};
>> +
>> +#endif /* _ASM_RISCV_DEVICE_H */
Thanks!
