On Wed, 28 Jun 2017 14:25:00 PDT (-0700), james.hogan@xxxxxxxxxx wrote:
> Hi Palmer,
>
> On Wed, Jun 28, 2017 at 11:55:38AM -0700, Palmer Dabbelt wrote:
>> + select SYSRISCV_ATOMIC if !ISA_A
> ...
>> +config SYSRISCV_ATOMIC
>> + bool "Include support for atomic operation syscalls"
>> + default !ISA_A
>> + help
>> + If atomic memory instructions are present, i.e.,
>> + CONFIG_ISA_A, this includes support for the syscall that
>> + provides atomic accesses. This is only useful to run
>> + binaries that require atomic access but were compiled with
>> + -mno-atomic.
>> +
>> + If CONFIG_ISA_A is unset, this option is mandatory.
>> +
>> + If you don't know what to do here, say N.
>
> Can this be removed now that you mentioned the atomics syscall being
> mandatory? I can't find any other references to it.
Oh, sorry, I must have just missed it when swizzling that around. I'll remove
it as part of our v4.
diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index 38c8112861fd..9f587af28910 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -155,20 +155,6 @@ config ISA_A
If you don't know what to do here, say Y.
-config SYSRISCV_ATOMIC
- bool "Include support for atomic operation syscalls"
- default !ISA_A
- help
- If atomic memory instructions are present, i.e.,
- CONFIG_ISA_A, this includes support for the syscall that
- provides atomic accesses. This is only useful to run
- binaries that require atomic access but were compiled with
- -mno-atomic.
-
- If CONFIG_ISA_A is unset, this option is mandatory.
-
- If you don't know what to do here, say N.
-
config RV_PUM
def_bool y
prompt "Protect User Memory" if EXPERT
Thanks for catching this!
