On Wed, Jun 28, 2017 at 11:55:34AM -0700, Palmer Dabbelt wrote: > diff --git a/arch/riscv/include/asm/kprobes.h b/arch/riscv/include/asm/kprobes.h > new file mode 100644 > index 000000000000..1190de7a0f74 > --- /dev/null > +++ b/arch/riscv/include/asm/kprobes.h > @@ -0,0 +1,22 @@ ... > +#ifdef CONFIG_KPROBES > +#error "RISC-V doesn't skpport CONFIG_KPROBES" > +#endif I'm wondering where your fallback definition of e.g. NOKPROBE_SYMBOL comes from then. Could you just use the asm-generic one? > diff --git a/arch/riscv/kernel/process.c b/arch/riscv/kernel/process.c > new file mode 100644 > index 000000000000..b13d3ea3bf79 > --- /dev/null > +++ b/arch/riscv/kernel/process.c > @@ -0,0 +1,131 @@ ... > +void show_regs(struct pt_regs *regs) > +{ > + show_regs_print_info(KERN_DEFAULT); > + > + printk(KERN_CONT "sepc: " REG_FMT " ra : " REG_FMT " sp : " REG_FMT "\n", > + regs->sepc, regs->ra, regs->sp); I've noticed inconsistent use of pr_* and printk(KERN_* in this patchset. Maybe now would be the best time to switch everything to pr_*. > + /* Reset FPU context > + * frm: round to nearest, ties to even (IEEE default) > + * fflags: accrued exceptions cleared > + */ Similarly lots of multiline comments which don't follow the standard style in Documentation/process/coding-style.rst. Maybe now is the best time to convert if you're going to. Cheers James
Attachment:
signature.asc
Description: Digital signature