Re: [PATCH 8/9] RISC-V: User-facing API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Palmer Dabbelt <palmer@xxxxxxxxxxx>
Subject: Re: [PATCH 8/9] RISC-V: User-facing API
From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Date: Wed, 28 Jun 2017 23:52:45 +0200 (CEST)
Cc: peterz@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, mcgrof@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, sfr@xxxxxxxxxxxxxxxx, nicolas.dichtel@xxxxxxxxx, rmk+kernel@xxxxxxxxxxxxxxx, msalter@xxxxxxxxxx, tklauser@xxxxxxxxxx, will.deacon@xxxxxxx, james.hogan@xxxxxxxxxx, paul.gortmaker@xxxxxxxxxxxxx, linux@xxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, albert@xxxxxxxxxx
In-reply-to: <alpine.DEB.2.20.1706282336270.1890@nanos>
References: <20170606230007.19101-1-palmer@dabbelt.com> <20170628185538.1804-1-palmer@dabbelt.com> <20170628185538.1804-9-palmer@dabbelt.com> <alpine.DEB.2.20.1706282336270.1890@nanos>
User-agent: Alpine 2.20 (DEB 67 2015-01-07)

On Wed, 28 Jun 2017, Thomas Gleixner wrote:
> On Wed, 28 Jun 2017, Palmer Dabbelt wrote:
> > +	err = __get_user(prev, ptr);
> 
> Sigh. Type safety is overrated, right?

But the comment above your __get_user() implementation says:

+ * @ptr must have pointer-to-simple-variable type, and the result of
+ * dereferencing @ptr must be assignable to @x without a cast.

References:
- RISC-V Linux Port v2
  - From: Palmer Dabbelt
- RISC-V Linux Port v3
  - From: Palmer Dabbelt
- [PATCH 8/9] RISC-V: User-facing API
  - From: Palmer Dabbelt
- Re: [PATCH 8/9] RISC-V: User-facing API
  - From: Thomas Gleixner

Prev by Date: Re: [PATCH 8/9] RISC-V: User-facing API
Next by Date: Re: [PATCH 8/9] RISC-V: User-facing API
Previous by thread: Re: [PATCH 8/9] RISC-V: User-facing API
Next by thread: Re: [PATCH 8/9] RISC-V: User-facing API
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]