On Wed, Jun 21, 2017 at 12:53:03PM +0300, Kirill A. Shutemov wrote: > On Tue, Jun 20, 2017 at 04:54:38PM +0100, Catalin Marinas wrote: > > For arm64, I don't see the point of a cmpxchg, so something like below > > would do (it needs proper testing though): > > Right. cmpxchg is required for x86 PAE, as it has sizeof(pmd_t) > > sizeof(long). We don't have 8-byte xchg() there. > > Thanks, for the patch. I assume, I can use your signed-off-by, right? Yes. And maybe some text (well, I just copied yours): ---------------8<-------------- arm64: Provide pmdp_establish() helper We need an atomic way to setup pmd page table entry, avoiding races with CPU setting dirty/accessed bits. This is required to implement pmdp_invalidate() that doesn't lose these bits. Signed-off-by: Catalin Marinas <catalin.marinas@xxxxxxx> ---------------8<-------------- > Any chance you could help me with arm too? I'll have a look. -- Catalin