On 06/19/2017 08:18 AM, Yury Norov wrote: > On Mon, Jun 19, 2017 at 02:51:08AM +0300, Yury Norov wrote: >> Hi Florian, >> >> Some questions and thoughts inline. >> >> Yury >> >> On Fri, Jun 16, 2017 at 05:07:42PM -0700, Florian Fainelli wrote: >>> Define a generic fncpy() implementation largely based on the ARM version >>> that requires an 8 bytes alignment for the destination address where to >>> copy this function as well as the function's own address. >>> >>> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx> >>> --- >>> include/asm-generic/fncpy.h | 93 +++++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 93 insertions(+) >>> create mode 100644 include/asm-generic/fncpy.h > > One else thing I forgot to ask - now you have the generic > implementation for fncpy(), so do you really need to save arm > version of it? Yes, it needs to deal with the Thumb bit, and there is no point in making the generic implementation extremely flexible to support that special case. Thanks -- Florian
