On 06/14/2017 12:06 PM, Steven Rostedt wrote:
On Tue, 13 Jun 2017 16:21:48 -0500
Jeremy Linton <jeremy.linton@xxxxxxx> wrote:
Hmm, I have to audit some userspace code to see if this is used. The
enum_map was a debug feature, but it could have been used by some tools.
I thought perf was using it, but I was mistaken. I didn't find anything
using it, but to be on the safe side I placed this patch last so it
could be dropped if a user was found. The CONFIG option seems to be
disabled in the couple distro's I checked, further indicating that if
someone is using it, they are seemingly obscure.
I pulled in all your patches but the samples one. Could you update that
with a use case as well. You can create some crazy struct that you want
to get the size of, or whatever. Maybe make an array out of it? Or I
can come up with something creative.
I was actually working on that, it seems that the existing sample has
the problem because of the __print_array(...sizeof(int)) case. So I
think my general plan was just to update it to TRACE_DEFINE_SIZEOF(int).
Do you want a more complex example?
But this lead me to discover a number of other __print_array() cases
where people have hardcoded the size, so I was running through those and
converting them to sizeof() since it should work now.
I'll start testing your patches and do a push in a few days.
-- Steve
