On Wed, Jun 07, 2017 at 09:19:49AM +0200, Geert Uytterhoeven wrote: > CC pci folks Ok, replying with pci folks in Cc then :) Weak symbols have (rightly) gotten a bad reputation, so maybe we should approach this without them. It seems we have a large number of emptry pcibios_fixup_bus calls alreayd, so I think we should simply have the architectures that do define it define a Kconfig or header symbol and not call it at all otherwise. For the ones that exist as lot just seem to call pci_read_bridge_bases and/or pcibios_fixup_device_resources in one form or another, and I wonder why we even need the arch indirection for that. Similarly for pcibios_align_resource: a lot of architetures seem to have a noop, and the once that don't mostly seem copy and paste code, so we should again have a symbol for architectures to opt into it, and we probably should have a generic helper for the VGA window mirroring code instead of duplicating it multiple times.