2017-05-16 2:04 GMT+09:00 Olof Johansson <olof@xxxxxxxxx>: > On Mon, May 15, 2017 at 8:48 AM, Russell King - ARM Linux > <linux@xxxxxxxxxxxxxxx> wrote: >> On Mon, May 15, 2017 at 08:27:54AM -0700, Olof Johansson wrote: >>> On Mon, May 15, 2017 at 7:47 AM, Rob Herring <robh+dt@xxxxxxxxxx> wrote: >>> > On Mon, May 15, 2017 at 9:26 AM, Russell King - ARM Linux >>> > <linux@xxxxxxxxxxxxxxx> wrote: >>> >> Maybe what we should do is: >>> >> >>> >> mkdir include/dt >>> >> git mv include/dt-bindings include/dt >>> >> for arch in arch/*; do >>> >> dts=$arch/boot/dts >>> >> if [ -d $dts ]; then >>> >> a=include/dt/$(basename $arch) >>> >> ln -s $dts $a >>> >> git add $a >>> >> fi >>> >> done >>> >> ... fixup scripts/Makefile.lib ... >>> >> git commit >>> > >>> > That would just break every existing include in dts files. >>> >>> It doesn't break dts includes if done together with a change in -I, >>> but it might break includes from the driver side (or needs another -I >>> there). >> >> Good point. >> >> We could leave include/dt-bindings where it is, and just do the rest of >> it for the cross-arch includes. Slightly less tidy but should have a >> lower impact. > > I think you're proposing this? > include/dt-bindings > include/dt/$arch -> ../../arch/$arch/boot/dts/ > > And then having -I$(srctree)include/dt as argument to dtc? > > That'd work but have the same drawback as I mentioned to Rob about > having several -I statements at different levels of the include > hierarchy, the same file could be reached through <dt/$arch/> and > <$arch/>. Not a showstopper but since Rob seems to be OK with the link > hierarchy living under scripts/dtc, I'd prefer to just stick to that. > > This is all pretty isolated, and if we want to move it somewhere else > later for some reason, we should be able to do so without impacting > DTS and drivers. > As I pointed out in https://patchwork.kernel.org/patch/9726699/ /include/ "arm/foo.dtsi" will make sense, so I'd like to to improve it some time later. Anyway, this patch fixes the circular symlinks. Reviewed-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> -- Best Regards Masahiro Yamada
