Re: [RFC PATCH v4 07/28] x86: Provide general kernel support for memory encryption

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Tom Lendacky <thomas.lendacky@xxxxxxx>, linux-arch@xxxxxxxxxxxxxxx, linux-efi@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kasan-dev@xxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx
Subject: Re: [RFC PATCH v4 07/28] x86: Provide general kernel support for memory encryption
From: Dave Hansen <dave.hansen@xxxxxxxxx>
Date: Wed, 22 Feb 2017 10:13:57 -0800
Cc: Rik van Riel <riel@xxxxxxxxxx>, Radim Krčmář <rkrcmar@xxxxxxxxxx>, Toshimitsu Kani <toshi.kani@xxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Brijesh Singh <brijesh.singh@xxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Alexander Potapenko <glider@xxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Larry Woodman <lwoodman@xxxxxxxxxx>, Dmitry Vyukov <dvyukov@xxxxxxxxxx>
In-reply-to: <20170216154332.19244.55451.stgit@tlendack-t1.amdoffice.net>
References: <20170216154158.19244.66630.stgit@tlendack-t1.amdoffice.net> <20170216154332.19244.55451.stgit@tlendack-t1.amdoffice.net>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

On 02/16/2017 07:43 AM, Tom Lendacky wrote:
> )
> @@ -673,7 +683,7 @@ static inline unsigned long pgd_page_vaddr(pgd_t pgd)
>   * Currently stuck as a macro due to indirect forward reference to
>   * linux/mmzone.h's __section_mem_map_addr() definition:
>   */
> -#define pgd_page(pgd)		pfn_to_page(pgd_val(pgd) >> PAGE_SHIFT)
> +#define pgd_page(pgd)	pfn_to_page(pgd_pfn(pgd))

FWIW, these seem like good cleanups that can go in separately from the
rest of your series.

References:
- [RFC PATCH v4 00/28] x86: Secure Memory Encryption (AMD)
  - From: Tom Lendacky
- [RFC PATCH v4 07/28] x86: Provide general kernel support for memory encryption
  - From: Tom Lendacky

Prev by Date: Re: [RFC PATCH v4 07/28] x86: Provide general kernel support for memory encryption
Next by Date: Re: [RFC PATCH v4 10/28] x86: Insure that boot memory areas are mapped properly
Previous by thread: Re: [RFC PATCH v4 07/28] x86: Provide general kernel support for memory encryption
Next by thread: [RFC PATCH v4 09/28] x86: Add support for early encryption/decryption of memory
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]