Re: [RFC][PATCH 02/31] locking,alpha: Implement atomic{,64}_fetch_{add,sub,and,andnot,or,xor}()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Peter Zijlstra <peterz@xxxxxxxxxxxxx>, torvalds@xxxxxxxxxxxxxxxxxxxx, mingo@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, will.deacon@xxxxxxx, paulmck@xxxxxxxxxxxxxxxxxx, boqun.feng@xxxxxxxxx, waiman.long@xxxxxxx, fweisbec@xxxxxxxxx
Subject: Re: [RFC][PATCH 02/31] locking,alpha: Implement atomic{,64}_fetch_{add,sub,and,andnot,or,xor}()
From: Richard Henderson <rth@xxxxxxxxxxx>
Date: Fri, 22 Apr 2016 09:57:04 -0700
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, vgupta@xxxxxxxxxxxx, linux@xxxxxxxxxxxxxxxx, egtvedt@xxxxxxxxxxxx, realmz6@xxxxxxxxx, ysato@xxxxxxxxxxxxxxxxxxxx, rkuo@xxxxxxxxxxxxxx, tony.luck@xxxxxxxxx, geert@xxxxxxxxxxxxxx, james.hogan@xxxxxxxxxx, ralf@xxxxxxxxxxxxxx, dhowells@xxxxxxxxxx, jejb@xxxxxxxxxxxxxxxx, mpe@xxxxxxxxxxxxxx, schwidefsky@xxxxxxxxxx, dalias@xxxxxxxx, davem@xxxxxxxxxxxxx, cmetcalf@xxxxxxxxxxxx, jcmvbkbc@xxxxxxxxx, arnd@xxxxxxxx, dbueso@xxxxxxx, fengguang.wu@xxxxxxxxx
In-reply-to: <20160422093923.156825130@infradead.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1

On 04/22/2016 02:04 AM, Peter Zijlstra wrote:
> +	"1:	ldl_l %0,%1\n"						\
> +	"       mov %0,%2\n"						\
> +	"	" #asm_op " %0,%3,%0\n"					\
> +	"	stl_c %0,%1\n"						\

No need for the extra mov.

	ldl_l %2,%1
	asm_op %2,%3,%0
	stl_c %0,%1


r~
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Follow-Ups:
- Re: [RFC][PATCH 02/31] locking,alpha: Implement atomic{,64}_fetch_{add,sub,and,andnot,or,xor}()
  - From: Peter Zijlstra

References:
- [RFC][PATCH 00/31] implement atomic_fetch_$op
  - From: Peter Zijlstra
- [RFC][PATCH 02/31] locking,alpha: Implement atomic{,64}_fetch_{add,sub,and,andnot,or,xor}()
  - From: Peter Zijlstra

Prev by Date: Re: [PATCH 18/25] arm64: ilp32: introduce binfmt_ilp32.c
Next by Date: Re: [PATCH 19/25] arm64: ptrace: handle ptrace_request differently for aarch32 and ilp32
Previous by thread: [RFC][PATCH 02/31] locking,alpha: Implement atomic{,64}_fetch_{add,sub,and,andnot,or,xor}()
Next by thread: Re: [RFC][PATCH 02/31] locking,alpha: Implement atomic{,64}_fetch_{add,sub,and,andnot,or,xor}()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Newbies] [x86 Platform Driver] [Netdev] [Linux Wireless] [Netfilter] [Bugtraq] [Linux Filesystems] [Yosemite Discussion] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper]