Re: [PATCH 03/18] mm: make vm_munmap killable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri 11-03-16 11:06:41, Vlastimil Babka wrote:
> On 02/29/2016 02:26 PM, Michal Hocko wrote:
> >From: Michal Hocko <mhocko@xxxxxxxx>
> >
> >Almost all current users of vm_munmap are ignoring the return value
> >and so they do not handle potential error. This means that some VMAs
> 
>    1   7834  arch/x86/kvm/x86.c <<__x86_set_memory_region>>
> 
>              r = vm_munmap(old.userspace_addr, old.npages * PAGE_SIZE);
>              WARN_ON(r < 0);
> 
> This warning will potentially add noise to OOM output?

Would it be harmfull though? I mean the warning is just goofy. I can
make it not warn on (r < 0 && r != -EINTR) but is it worth bothering?

Thanks!
-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux