On Fri, Dec 11, 2015 at 8:50 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote: > On Fri, Dec 11, 2015 at 9:00 AM, Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> wrote: >> On Wed, Dec 9, 2015 at 11:43 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote: >>> Several places in the kernel expect to use "on" and "off" for their >>> boolean signifiers, so add them to strtobool. >>> + if (!s) >>> + return -EINVAL; >>> + >> >> This change I think is better to do separately. Do we have even need for it? > > I'm happy to separate it, sure. I added it here because several of the > __setup and param callers do a check for !NULL input, and it made this > cleaner. Also it seems sensible to do this check anyway. OK. >>> + default: >>> + return -EINVAL; >>> + } >>> + break; >>> default: >>> return -EINVAL; >> >> Maybe in both cases >> default: >> break; >> } >> … >> } >> return -EINVAL; > > I went back and forth on this. To switch to the fall-back being EINVAL > meant I had to change all the other "breaks" into "return 0", and it > just looked ugly to me. If that is preferred, though, I'm happy to do > it. I have no strong feelings about that, I prefer whatever looks neater. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
