On Monday 07 December 2015 15:12:59 Andy Lutomirski wrote: > Hi all- > > Every time I look at is_compat_task, I cringe. That function > determines whether we're in a compat syscall, not whether we're in a > compat task. There are probably architectures (arm64?) under which > these are the same conditions, but they are definitely *not* the same > thing on x86. > > Can we just fix it? I propose the following patch: > > $ find -type f |xargs sed -i -e 's/is_compat_task/in_compat_syscall/g' > > If there's general agreement, can we do that at the end of the next > merge window? > > I could also send a patch series to add in_compat_syscall, change all > the users, then delete the old stuff, but that seems overcomplicated > for something that's literally just renaming a token. As far as I know, x86 is the special case here, on all other architectures, this actually checks the task, and it's impossible to call a system call of the other kind. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
